rebenitez1802 commented on code in PR #43523: URL: https://github.com/apache/superset/pull/43523#discussion_r3991393428
########## superset/config.py: ########## @@ -1289,6 +1289,13 @@ def sync_theme_logo_href( # How long to treat a COMPUTING cache entry as an active lease before considering # the worker stuck. Should exceed the task soft_time_limit (300 s) by a margin. THUMBNAIL_COMPUTING_CACHE_TTL = int(timedelta(seconds=360).total_seconds()) +# How long a successfully-rendered (UPDATED) thumbnail stays servable before it +# is recomputed. Cache backends without TTL eviction (e.g. S3) never expire +# entries on their own, so without this a once-rendered thumbnail is served +# forever even if it was a valid-but-blank capture. Defaults to match the +# THUMBNAIL_CACHE_CONFIG CACHE_DEFAULT_TIMEOUT (7 days) so freshness matches what +# TTL-evicting backends already enforce. Set to 0 or None to disable (opt out). +THUMBNAIL_UPDATED_CACHE_TTL = int(timedelta(days=7).total_seconds()) Review Comment: Done — documented `THUMBNAIL_UPDATED_CACHE_TTL` under **Caching Thumbnails** in `docs/admin_docs/configuration/cache.mdx`: the setting, its `0`/`None` opt-out, the affected/excluded paths, and worker-first rollout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
