FrancescoCastaldi commented on PR #43584: URL: https://github.com/apache/superset/pull/43584#issuecomment-5640599674
Thanks @gabotorresruiz and @rusackas! I've addressed the nit: now that the icon lives outside the label, I converted the description info icon from the ole="button" <span> workaround to a native <button type="button">, removed the eslint disable rule and workaround comment, and added an explicit assertion in ControlHeader.test.tsx to verify the button tag. Formatting and lint checks are passing cleanly. Ready for merge whenever you are! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
