mikebridge commented on PR #44025: URL: https://github.com/apache/superset/pull/44025#issuecomment-5639848221
The codeant/bito finding on `_changes_authoritative_colors` is correct and fixed in 20f6d1d910: an explicit `color_scheme: null` (or `label_colors: null`) compared equal to `metadata.get(key)`'s None default when the stored metadata lacked the key — yet the DAO writes every provided key, so the managed dashboard's exported `json_metadata` would have gained a literal null entry. The comparison now uses a missing-key sentinel (absent ≠ null), pinned by parametrized tests for both authoritative keys. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JRLEJS4mUqKBoPjSjviKUW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
