maxmelnick opened a new pull request #8630: fixes error creating a new database 
due to Malformed JSON error for empty Secure extras field
URL: https://github.com/apache/incubator-superset/pull/8630
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   
   ### SUMMARY
   Fixes #8628 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   See #8628 for before screenshots.
   
   After screenshots demonstrate I am able to have a blank `Secure extras` 
field and successfully test a new connection.
   
   ![Screen Shot 2019-11-21 at 4 18 19 
PM](https://user-images.githubusercontent.com/4043751/69389955-935c8600-0c9b-11ea-8440-48168bae6ed9.png)
   ![Screen Shot 2019-11-21 at 4 18 05 
PM](https://user-images.githubusercontent.com/4043751/69389959-96f00d00-0c9b-11ea-803c-1bd288e34ace.png)
   
   
   ### TEST PLAN
   
   Tested locally in docker.
   
   ```
   git clone https://github.com/apache/incubator-superset/
   cd incubator-superset/contrib/docker
   docker-compose run --rm superset ./docker-init.sh
   docker-compose up
   # then tested adding a new database in UI and was successful
   ```
   
   Note: I tested an empty `Secure extra` field, as well as explicitly setting 
`Secure extra` field = `{}` in UI to test case when someone provides valid JSON 
for `Secure extra` field.
   
   ### ADDITIONAL INFORMATION
   - [ X] Has associated issue: Fixes #8628 
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to