maxmelnick commented on a change in pull request #8630: fixes error creating a
new database due to Malformed JSON error for empty Secure extras field
URL:
https://github.com/apache/incubator-superset/pull/8630#discussion_r349433320
##########
File path: superset/templates/superset/models/database/macros.html
##########
@@ -40,7 +40,7 @@
name: $('#database_name').val(),
impersonate_user: $('#impersonate_user').is(':checked'),
extras: JSON.parse($("#extra").val()),
- encrypted_extra: JSON.parse($("#encrypted_extra").val()),
+ encrypted_extra: $("#encrypted_extra").val() ?
JSON.parse($("#encrypted_extra").val()) : {},
Review comment:
@mistercrunch - good point. I just pushed that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
