rusackas commented on PR #43238: URL: https://github.com/apache/superset/pull/43238#issuecomment-5647578710
@viharnani checking in, remiding that @sadpandajoe's newest review comments remain open: the stale `stackDimension` case where `indexOf` returns -1 and, with multiple metrics, the offset lands on the metric label instead of a real dimension, and using raw dimension values as object keys in both accumulators, so a value like `__proto__` or `constructor` writes onto the prototype instead of creating its own group. Both look like real bugs, not nits, worth fixing before this merges. Holler if you want a hand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
