rusackas commented on PR #43694: URL: https://github.com/apache/superset/pull/43694#issuecomment-5647584623
@Archita-kale just echoing that @sadpandajoe caught one more issue on pivot.py:217. Nullable extension dtypes (`Int64`, `Float64`, boolean) still crash on `fillna(<NULL>)` the same way the datetime/timedelta and categorical cases from the earlier threads do. That's four separate dtype paths that can raise or silently misreport, still open. Might be worth handling this by upcasting to object dtype once in `_fill_dimension_column`, rather than adding a branch every time a new dtype turns up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
