rusackas commented on PR #44140: URL: https://github.com/apache/superset/pull/44140#issuecomment-5647597930
@liang-wenjie thanks for tackling this! Couple of things before it can land: * the bito thread on `timeRange.ts`'s `addMonths` looks right, going back a month from a month-end date (like the 31st) overflows into the wrong day, which'll throw off the point-to-point comparisons. * pre-commit's failing on hardcoded hex colors in `transformProps.ts` (should be theme tokens) and unit-tests never finished, so this isn't mergeable as-is. Say the word if you want a hand, we can push some commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
