rusackas commented on PR #44142: URL: https://github.com/apache/superset/pull/44142#issuecomment-5647611016
@Ujjwaljain16 nice work tracking down the actual removed/renamed permissions here, the migration docstrings are thorough. Pre-commit's failing for real though: `security_converge_test.py:202` passes a `dict[Pvm, tuple[Pvm]]` where `migrate_roles` expects `dict[Pvm, tuple[Pvm, ...]]`, dicts are invariant so mypy rejects it. Once that's fixed I think this is good to go. I'll see about making that touchup... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
