rusackas commented on PR #37412:
URL: https://github.com/apache/superset/pull/37412#issuecomment-5647674604

   Heya @reynoldmorel, this has drifted from `master` and needs a rebase.
   
   CI's failing (lint-frontend, one jest shard) rather than just blocked on 
review. 
   
   Codeant's also flagging what looks like a real bug in 
`addLabelMapToVerboseMap`: it splits the key on spaces before matching labels, 
so a multi-word label like "1 week ago" (from your own docstring example) would 
never match. Might be worth fixing that before the rebase. 
   
   Happy to help if you want.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to