rusackas commented on PR #43759: URL: https://github.com/apache/superset/pull/43759#issuecomment-5647767800
@sadpandajoe's thread on the rate limiter is still open, and it seems correct. `get` then `set` isn't atomic, so a burst of concurrent previews can all read the same count and slip past the limit, which is what this guard exists for. Worth swapping to an atomic incr on the cache backend instead of get+threshold+set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
