aminghadersohi opened a new pull request, #44218: URL: https://github.com/apache/superset/pull/44218
### SUMMARY Extracts a self-contained dashboard Excel export correction from #43771 so that the Sunburst feature PR has a smaller, more reviewable scope. When a saved Table chart uses server pagination and its query context must be rebuilt, mark the rebuild as an XLSX download. This requests the configured full row limit instead of the interactive page size and avoids producing a row-count worksheet. This change is independent of Sunburst and can land before #43771. Once merged, #43771 can absorb master normally and its corresponding diff disappears without rewriting either branch. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; backend export behavior only. ### TESTING INSTRUCTIONS ```bash PYTHONPATH="$PWD/superset-core/src:$PYTHONPATH" pytest -q tests/unit_tests/tasks/test_export_dashboard_excel.py # 49 passed pre-commit run # Passed for all staged files. ``` Regression coverage verifies aggregate and raw paginated Tables export the configured 1,000-row limit rather than a 10-row interactive page, reset the offset, and omit the count query. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
