aminghadersohi commented on PR #43771: URL: https://github.com/apache/superset/pull/43771#issuecomment-5658734358
Thanks — I audited the full 77-file diff rather than only relabeling it. I found 3 Sunburst-only files (+5,866 lines, mostly the exhaustive regression suite), 30 mixed Sunburst/shared chart files (+7,651/-2,185), 33 shared MCP contract files (+10,016/-611), and 11 clearly incidental files (+249/-32). I separated the independently testable incidental work without rewriting this ready PR: - #44218: dashboard Excel pagination rebuild (3 files, focused test: 49 passed). Those files are removed from this PR. - #44219: strict DataFrame/non-finite JSON projection (6 files, focused tests: 150 passed). This should land before #43771; a normal merge of master then removes the duplicated files here. - Dropped the unrelated Python-unit timeout edit entirely. I tested removing the DataFrame foundation from #43771 before #44219 lands; it produces 29 focused failures across the real query-context materialization and Sunburst data paths. I therefore did not leave this PR red or hide that dependency behind a mechanical split. With only the Excel extraction and timeout removal applied, the broad focused matrix passes (890 passed, 1 skipped), including Sunburst, both Gauge suites, query-result/get-data, and dashboard export coverage; staged-file pre-commit also passes. The PR body now has the complete four-group review map, dependency explanation, and explicit landing order: #44218 and #44219 first, normal-merge master into #43771, then #43771. The remaining mixed/shared code meets at the compile, preview, update, and typed query-result boundaries, so further extraction should use the same land-first/normal-merge sequence rather than duplicating code or rewriting history. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
