I3eka commented on PR #43133: URL: https://github.com/apache/superset/pull/43133#issuecomment-5662829820
September 14 review follow-up, head `4ba174f3e2`, synchronized to master `24fe87e5` at the 10:46 UTC cutoff. Addressed the authoring/layout and setup-doc findings: reused upstream's `validate_dashboard_layout` instead of maintaining a second validator; check reachable requested charts and normalize derived parent paths; documented `ENABLE_EXTENSIONS`, migration before init, the optional FastMCP dependency, provider-install ordering/restart, and the actual suggestions/stream-prefix settings. Verification of the authoring changes: 818 Python unit tests (AI, dashboard validation/generation, and affected upstream access-error tests) and 129 frontend tests (all 105 AI tests plus the affected upstream chart/access-error tests) passed. The common Escape test failure was reproduced with the locked user-event and fixed without changing UI behavior. Full branch pre-commit passed once the JS workspace build prerequisites were present. The preceding head's GitHub checks are green; the final upstream merge requires a fresh run. I replied individually to all 42 new human inline comments and reviewed the updated coverage/preview reports. The authoring timeout/thread-lifetime issue remains a blocker on our side and its thread has been reopened. Real authenticated persisted-authoring integration coverage is still missing; unit tests are not a substitute. The other inherited base API/runtime/UI/retention findings also remain open. SIP/ownership follow-up: https://github.com/apache/superset/pull/42805#issuecomment-5659710194. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
