eugeneo17 commented on PR #43303: URL: https://github.com/apache/superset/pull/43303#issuecomment-5663322875
@rusackas @sadpandajoe Thanks for the thorough pass, and sorry for the delay. Pushed two commits. d7ae729487 gets CI green (the lint-frontend registry `--check` and the pre-commit `oxfmt` hook were both failing on the same generated file, because the generator output was not oxfmt-idempotent; it is now), maps Chord and Cartodiagram, and fixes the raw-mode `all_columns` and `row_limit` fallbacks. 065f8b4f5 covers the rest: the backfill race guard, the import summary counter, the mini-racer distribution plus the Docker bundle copy, and fixture reconciliation. The two you called out are already in the tree with tests: the AND/OR predicate join goes through `split_adhoc_filters_into_base_filters` (parenthesized and trailing-comment safe), and the foreign `slice_id` is dropped before the V8 builder. I have replied on each thread and resolved the ones that are done. Three I left open with a proposed direction where it is a design call. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
