Ujjwaljain16 commented on PR #43974: URL: https://github.com/apache/superset/pull/43974#issuecomment-5663972705
@gabotorresruiz thanks for the review and approval i followed up on the `odbc_connect` vs `connect_args["database"]` precedence question and verified the behavior against SQLAlchemy 2.0.52 + the Microsoft ODBC Driver 18 for SQL Server the implementation now follows the actual runtime precedence: * embedded `Database=` in `odbc_connect` wins (including an explicitly empty value, which fails closed) * otherwise the URL database is used * `connect_args["database"]` is only a fallback when the connection string has no database * `Initial Catalog=` is intentionally not recognized, since it isn't a valid database-selection keyword for this ODBC driver i also added regression coverage for duplicate `Database=` keys and, importantly, a `raise_for_access()`-level test covering conflicting `odbc_connect` and `connect_args` values the changes are now ready for another look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
