mikebridge commented on code in PR #44094:
URL: https://github.com/apache/superset/pull/44094#discussion_r4007507110
##########
superset/mcp_service/dashboard/tool/manage_dashboard_certification.py:
##########
@@ -92,6 +92,25 @@ def manage_dashboard_certification(
warnings=["No fields provided; dashboard unchanged."],
)
+ # Externally managed dashboards refuse certification CHANGES (the
+ # no-field inspect path above still returns current values): their
+ # source of truth lives outside Superset, so a badge set here would be
+ # overwritten (or drift from the certifying system) on the next
+ # external sync. This tool writes by direct attribute assignment +
+ # commit rather than through a command, so no command-layer check can
+ # protect it — the refusal must live in the tool itself, after the
+ # editorship check, where a caller with no edit rights keeps getting
+ # the plain editorship denial.
+ if dashboard.is_managed_externally:
Review Comment:
Ratified as a follow-up: agreed the owners/roles/update_dashboard tools
share the exact command-bypassing write path, and the shared-base
`managed_externally` field + refusal shape from this PR were built so the hoist
is mechanical. Tracked as sc-120483, which also carries the one open policy
question (whether owners/roles governance is Superset-local like `published` or
external-content like title/metadata) for Elizabeth; kept out of this PR to
avoid widening it mid-review. Leaving this thread open for you to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
