aminghadersohi commented on code in PR #44179: URL: https://github.com/apache/superset/pull/44179#discussion_r4007586811
########## docs/docs/using-superset/recently-archived.mdx: ########## @@ -54,6 +54,12 @@ returns to its normal list and disappears from the archive. Recovering is limited to the object's editors and admins; you can only recover objects you are able to see in this view. +Seeing an archived object and acting on it are separate permissions: objects +you can view but not edit still appear in the list, but their rows carry no +actions. The **Recover** and **Delete permanently** buttons appear only if you +have edit permission for that object type; recovering a specific object can +still be refused if you are not one of its editors. Review Comment: My round-2 span started one sentence too late: "their rows carry no actions" makes the same per-object claim I flagged next door. Under the class-level gate, an object you can view but not edit does show actions if you have write on its type. ```suggestion Seeing an archived object and acting on it are separate permissions: objects you can view but not edit still appear in the list. The **Recover** and **Delete permanently** buttons appear only if you have edit permission for that object type; recovering a specific object can still be refused if you are not one of its editors. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
