[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8636: [dashboard scoped filters] Add all time related options to filter scoped settings

Fri, 22 Nov 2019 16:53:48 -0800 

graceguo-supercat opened a new pull request #8636: [dashboard scoped filters] 
Add all time related options to filter scoped settings
URL: https://github.com/apache/incubator-superset/pull/8636
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Time filter has a few checkbox options: 
   
   - Show SQL Granularity Dropdown 
   - Show SQL Time Column
   - Show Druid Granularity Dropdown
   - Show Druid Time Origin
   <img width="381" alt="Screen Shot 2019-11-22 at 4 50 32 PM" 
src="https://user-images.githubusercontent.com/27990562/69469900-41be0500-0d48-11ea-959b-7965f263ac59.png";>
   
   In #8590 it is not handled in the scoped filters settings. so when user 
change one option from dashboard, it will throw js errors:
   <img width="337" alt="Screen Shot 2019-11-22 at 4 44 32 PM" 
src="https://user-images.githubusercontent.com/27990562/69469748-5fd73580-0d47-11ea-9f60-229ec1c49427.png";>
   
   
   At the same time, user reported a bug that if those options had a value, it 
is not get pre-populated into filter box.
   
   
   These 2 issues have same root cause: We need to map and initialize those 
options during dashboard initialization.
   
   ### TEST PLAN
   manual test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @etr2460 @michellethomas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to