codeant-ai-for-open-source[bot] commented on code in PR #43838:
URL: https://github.com/apache/superset/pull/43838#discussion_r4007973303
##########
superset/versioning/activity/render.py:
##########
@@ -168,7 +167,7 @@ def apply_record_decoration(
record["impact"] = None
else:
record["summary"] = _build_summary(api_kind, record)
- record["impact"] = impact_for_record(record, path_kind,
impact_counts)
+ record["impact"] = impact_for_record(record, path_kind,
impact_refs)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag retaining or populating the `impact` field in activity
rendering; this is intentional per the documented redaction design.
**Applied to:**
- `superset/versioning/activity/render.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
