deepujain commented on code in PR #43806:
URL: https://github.com/apache/superset/pull/43806#discussion_r4010363262
##########
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx:
##########
@@ -34,6 +34,52 @@ const drag = (
const isDragged = () => !!document.querySelector('.react-draggable-dragged');
+describe('mergeResizableConfig', () => {
Review Comment:
Implemented in e110c21a73. The new test renders Modal with a partial
resizeConfig and asserts the actual Resizable handle set, so it will fail if
CustomModal stops forwarding the merged defaults. I also ran the focused suite
(10/10 passing), formatting, lint, package builds, and the root type check.
Thanks for catching the boundary gap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
