deepujain opened a new pull request, #44271: URL: https://github.com/apache/superset/pull/44271
### SUMMARY Preserve HTTP response metadata when `getClientErrorObject` falls back from JSON parsing to text parsing. This makes the response status authoritative for contextual permission messages, including HTML and plain-text 403 responses returned by proxies, WAFs, and SSO gateways. This also adds a shared message-selection helper and migrates the tag loader, native-filter column and dataset loaders, and dashboard save errors away from literal `"Forbidden"` string comparisons. Fixes #44268 ### TESTING INSTRUCTIONS From `superset-frontend`: ```bash npm run test -- superset-ui-core/test/query/getClientErrorObject.test.ts src/dashboard/actions/dashboardState.test.ts src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ColumnSelect.test.tsx src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DatasetSelect.test.tsx src/components/Tag/utils.test.tsx npm run plugins:build npm run type ``` The targeted Jest run should report 5 passing suites and 81 passing tests. The package build and TypeScript check should complete without errors. ### ADDITIONAL INFORMATION - [x] Has associated issue: #44268 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
