codeant-ai-for-open-source[bot] commented on code in PR #44282:
URL: https://github.com/apache/superset/pull/44282#discussion_r4012238940
##########
superset/db_engine_specs/trino.py:
##########
@@ -182,6 +213,57 @@ class TrinoEngineSpec(PrestoBaseEngineSpec):
supports_oauth2 = True
oauth2_token_request_type = "data" # noqa: S105
+ @classmethod
+ def build_sqlalchemy_uri(
+ cls,
+ parameters: BasicParametersType,
+ encrypted_extra: dict[str, str] | None = None,
+ ) -> str:
+ """
+ Build the SQLAlchemy URI from the dynamic form parameters.
+
+ Mirrors ``BasicParametersMixin.build_sqlalchemy_uri`` but forces the
+ driverless ``trino`` scheme: ``default_driver`` is ``rest`` only so the
+ connection form is advertised, and ``trino+rest://`` is not a loadable
+ SQLAlchemy dialect.
+ """
+ # make a copy so that we don't update the original
+ query = parameters.get("query", {}).copy()
+ if parameters.get("encryption"):
+ query.update(cls.encryption_parameters)
+
+ return URL.create(
+ cls.engine,
+ username=parameters.get("username"),
+ password=parameters.get("password"),
+ host=parameters["host"],
+ port=parameters["port"],
+ database=parameters["database"],
+ query=query,
+ ).render_as_string(hide_password=False)
+
+ @classmethod
+ def adjust_engine_params(
+ cls,
+ uri: URL,
+ connect_args: dict[str, Any],
+ catalog: str | None = None,
+ schema: str | None = None,
+ ) -> tuple[URL, dict[str, Any]]:
+ # The dynamic form's encryption toggle is stored as a ``protocol``
query
+ # parameter (see ``encryption_parameters``). The Trino dialect reads
the
+ # scheme from ``connect_args["http_scheme"]``, not from the URI, so
+ # translate it here and drop the parameter from the URI.
+ if protocol := uri.query.get("protocol"):
+ uri = uri.set(
+ query={
+ key: value for key, value in uri.query.items() if key !=
"protocol"
+ }
+ )
+ connect_args.setdefault("http_scheme", protocol)
Review Comment:
**Suggestion:** When existing `connect_args` contains `http_scheme="http"`,
`protocol=https` is ignored, so an encrypted form connection still uses HTTP.
[security]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=663843870baf4c7aa9ecd84233533781&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=663843870baf4c7aa9ecd84233533781&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/trino.py
**Line:** 263:263
**Comment:**
*Security: When existing `connect_args` contains `http_scheme="http"`,
`protocol=https` is ignored, so an encrypted form connection still uses HTTP.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44282&comment_hash=3a96310715123b28950a71c389e1ed44596c9df4ec1dc60a297ee6a2e6fad157&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44282&comment_hash=3a96310715123b28950a71c389e1ed44596c9df4ec1dc60a297ee6a2e6fad157&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
