sadpandajoe commented on code in PR #44154:
URL: https://github.com/apache/superset/pull/44154#discussion_r4016081165
##########
superset-frontend/src/utils/downloadAsImage.tsx:
##########
@@ -379,6 +378,10 @@ export default function downloadAsImageOptimized(
isExactSelector = false,
theme?: SupersetTheme,
options: DownloadImageOptions = {},
+ // Bound via `useToasts()`/`bindActionCreators`, not the raw action creator
+ // from `actions.ts`: this module has no dispatch of its own, so an unbound
+ // creator would only build a Redux action object and never render a toast.
+ addWarningToast?: (message: string) => void,
Review Comment:
With `DashboardVirtualization` enabled, this callback never reaches
`forceLoadAllCharts`, which still invokes the unbound warning action creator;
if charts time out, the export proceeds with incomplete content and no warning
is rendered. Could we pass the bound callback through that helper and cover the
timeout path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
