kokhlo opened a new pull request, #44311:
URL: https://github.com/apache/superset/pull/44311

   ### Summary
   Backport of #43185 to the `6.2` release branch: export downloads 
(chart/dashboard/dataset/database/assets/saved-queries/themes) stop inheriting 
Superset's one-year `SEND_FILE_MAX_AGE_DEFAULT` and are served with `max_age=0` 
+ `no-store`/`no-cache`/`must-revalidate` instead.
   
   Same user-facing symptom as #41687 (fresh report: #44306): re-exporting the 
same resource IDs after a rename returns the year-cached archive until a hard 
refresh.
   
   ### Changes
   Identical shape to the `6.1` backport:
   - `superset/utils/core.py`: `send_export_zip()` helper + `COOKIE_TOKEN_RE` / 
`sanitize_cookie_token()` (master prerequisite missing on `6.2`).
   - 7 export endpoints switched to `send_export_zip(buf, filename)`.
   - Unit tests from #43185.
   - Conflicts resolved keeping the `6.2` import style (`prison`, `rison`), 
dropping `master`-only `superset.versioning.*` imports.
   
   ### Verification
   - Behavioral check of the helper in a Flask test request context 
(no-store/no-cache/must-revalidate/max-age=0, attachment, token echo, 
unsafe-token rejection); old path reproduces `max-age=31536000`.
   - `ruff check` clean on all touched files.
   
   Companion backport to `6.1`: TBD (will link).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to