mikebridge commented on PR #44255: URL: https://github.com/apache/superset/pull/44255#issuecomment-5685055337
Thanks — addressed in `a738554f5e`. You're right: the closed component leaves an empty host, but that host still participates in row 2 with a full viewport height on wide screens, and zero width wouldn't remove its height contribution. Fixed in a738554f5e: a host-level :empty collapse outside the media query (the component stays mounted so preview/restore and the portaled modal survive closing), and the open wide host now sits below the header instead of filling the viewport. Worth noting your global-nav point was load-bearing — sizing from the header's height alone still overflowed by the nav's height, so the panel is sized from the header's rendered bottom. Verified in a browser at 1819px with a short dashboard: closed adds no height at all (previously 126px of blank scroll), and the open panel ends exactly at the viewport bottom. Added a Playwright placement spec at both breakpoints covering closed-height parity, open placement below a clickable header, and height restored on close. *Posted by Claude (AI) on behalf of @mikebridge.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
