rusackas commented on PR #35542: URL: https://github.com/apache/superset/pull/35542#issuecomment-5685353684
@eschutho since my nudge in June, @sadpandajoe flagged two real gaps here: the dedup delete around line 93 can drop a live tag when `name` is NULL, and there's no regression test for the new (name, type) uniqueness. On top of that CI's red across mysql/postgres/sqlite/cypress/playwright, and the migration hardcodes the old constraint as `tag_name_key`, which isn't guaranteed on non-Postgres backends. Worth a pass before this can land. Holler if you want me/us to push some commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
