eschutho commented on PR #44316: URL: https://github.com/apache/superset/pull/44316#issuecomment-5684374788
@rebenitez1802 — routing this your way for review. 🦉 This is the render-time sibling of #44312 (and same bug-class as #44172 / #42366 / #42401): `get_virtual_table_metadata` only caught `SupersetSyntaxErrorException`, so a raw `jinja2.UndefinedError` re-raised from `process_template`'s **render** step (the non-function-call branch, `jinja_context.py`) escaped as an unhandled 500 on the "Sync columns from source" path. Fix adds an `except UndefinedError` branch that softens to `SupersetVirtualTableParseException`, matching the parse-time sibling. Since you already hold the #44312 context, bundling it here. Heads-up on load: you're carrying the most active reviews on the roster right now (plus #44172 + #44312 in flight). If you'd rather I re-route this one, say the word and I'll hand it to Gabriel — no problem at all. One CI note: several required checks are currently red (frontend `playwright`/`cypress` + the `test-postgres-required` gate), but they look unrelated to this backend-only diff — the underlying `test-postgres` matrix didn't run at this SHA. Worth confirming they go green before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
