geido commented on PR #43522: URL: https://github.com/apache/superset/pull/43522#issuecomment-5683549539
Superseded by #43719, which is merged. #43719 landed the same backend change (`metrics.metric_name`/`metrics.verbose_name` in the `drill_info` select columns, `DatasetMetricDrillInfoSchema`, and the `metrics` field on `DatasetDrillInfoSchema`) plus the two pieces this PR was missing: the `groupby=True` narrowing removed from `post_dump` so non-dimension columns resolve their Labels too, and the `SliceHeaderControls` fix so the `drill_info` fetch is no longer gated on Drill to detail alone — without that, this PR's API change stayed invisible to anyone with "View as table" but not Drill to detail, including default Gamma. Closing — a rebase here would produce an empty diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
