aminghadersohi opened a new pull request, #44320:
URL: https://github.com/apache/superset/pull/44320
### SUMMARY
**TL;DR**
- `.github/CODEOWNERS` has no entry for the MCP service, so PRs touching it
are
not routed to anyone who tracks the whole surface.
- Adds `@aminghadersohi` as code owner for `superset/mcp_service/`, its unit
tests, and the MCP devcontainer.
- This is opt-in ownership by an active maintainer of that subtree, not a
request for anyone else's review time — no existing block is changed and no
other contributor is added.
- Effect is advisory only: CODEOWNERS auto-requests review here; it does not
gate merge, since these paths are not under branch protection.
**Why**
`superset/mcp_service/` exposes a versioned tool contract consumed by
external
AI clients. Changes to tool names, input schemas, annotations, or error
shapes
are visible outside this repository and can break callers that this repo has
no
way to test against. It is the only substantial subtree in the project with
no
owner entry at all, so those changes currently reach review by chance.
Ownership here tracks actual maintenance rather than topic. Over the last
year,
of the commits touching these paths:
| Path | Total | `@aminghadersohi` |
|---|---|---|
| `superset/mcp_service/` | 380 | 220 (58%) |
| `tests/unit_tests/mcp_service/` | 331 | 188 (57%) |
**What**
Appends one block to `.github/CODEOWNERS`, in the style of the existing
blocks
(leading comment explaining why the block exists, trailing-slash directory
entries):
```
/superset/mcp_service/ @aminghadersohi
/tests/unit_tests/mcp_service/ @aminghadersohi
/tests/unit_tests/test_mcp_stdio_entrypoint.py @aminghadersohi
/.devcontainer/with-mcp/ @aminghadersohi
```
`test_mcp_stdio_entrypoint.py` is the unit test for
`superset/mcp_service/__main__.py` and is included so the entrypoint and its
test stay together; it sits outside `tests/unit_tests/mcp_service/` only by
file placement.
**Deliberately not included.** Three other MCP-named paths exist and are left
alone, because they are maintained by the core and extensions maintainers
rather than by the proposed owner, and adding an entry there would generate
review requests on other people's work:
| Path | Commits | By `@aminghadersohi` | Primarily maintained by |
|---|---|---|---|
| `superset/core/mcp` | 10 | 3, all from the original bring-up |
`@michael-s-molina`, `@villebro`, `@dpgaspar` |
| `superset-core/src/superset_core/mcp` | 6 | 2, same bring-up |
`@michael-s-molina`, `@villebro` |
`superset/core/mcp` and `superset-core/src/superset_core/mcp` hold the MCP
abstractions in `superset-core`, and their recent history is package
reorganisation and contribution-API work, not MCP service maintenance.
**Ordering.** CODEOWNERS is last-match-wins per path, so placement matters.
The
new block is appended at the end of the file and:
- is not overridden by anything, being last;
- does not overlap `/superset/config.py`, `/superset/extensions/`,
`/superset-extensions-cli/`, `/superset-frontend/src/extensions/` or
`/.github/` — all of those match disjoint paths;
- does not shadow the `**/*.geojson` and `**/*.ipynb` map rules. Those are
glob
patterns that a later directory rule could silently override, so it was
checked explicitly: there are no `.geojson` or `.ipynb` files under any of
the
four paths above, and the single tracked notebook lives in
`superset-frontend/plugins/plugin-chart-country-map/scripts/`.
**Prerequisite.** A CODEOWNERS entry is inert for an account without write
access. `@aminghadersohi` has `permission=write` on this repository, so the
entry takes effect.
### TESTING INSTRUCTIONS
CODEOWNERS is configuration, so verification is that the file still parses
and
every pattern resolves — a malformed line is silently ignored by GitHub
rather
than reported at merge time.
1. GitHub's own validation reports no errors for the file on this branch:
```
gh api repos/apache/superset/codeowners/errors?ref=codeowners-mcp-service
```
(Also visible in the UI: **Settings → Code owners**, or the "Code owners
errors" banner when viewing `.github/CODEOWNERS` on this branch.)
2. Every pattern in the file, including the four added, matches at least one
tracked path:
```
awk 'NF && $1 !~ /^#/ {print $1}' .github/CODEOWNERS \
| while read -r p; do printf '%-50s %s\n' "$p" "$(git ls-files "${p#/}"
| wc -l)"; done
```
The added patterns match 225, 174, 1 and 1 files respectively.
3. On the next PR touching `superset/mcp_service/`, `@aminghadersohi` appears
as an automatically requested reviewer.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
