sadpandajoe commented on code in PR #42112:
URL: https://github.com/apache/superset/pull/42112#discussion_r4020733314
##########
superset-frontend/plugins/plugin-chart-table/package.json:
##########
@@ -49,7 +49,7 @@
"@testing-library/user-event": "*",
"@types/react": "*",
"match-sorter": "^8.2.0",
- "react": "^18.3.0",
- "react-dom": "^18.3.0"
+ "react": "^18.3.0 || ^19.0.0",
Review Comment:
React 19 consumers cannot install this package under npm's normal peer
resolution: it depends on \`react-table@^7.8.0\`, whose React peer stops at 18,
while the root \`overrides\` used here are not inherited by the published
package. Can the dependency be made React-19-compatible, or should this peer
range remain at React 18?
##########
superset-frontend/src/dashboard/components/gridComponents/DynamicComponent/DynamicComponent.tsx:
##########
@@ -158,7 +158,9 @@ const DynamicComponent: FC<DynamicComponentProps> = ({
onResizeStop={onResizeStop}
>
<div
- ref={dragSourceRef}
+ ref={el => {
+ dragSourceRef(el);
Review Comment:
In view mode, \`DragDroppable\` omits \`dragSourceRef\`, so this ref
callback calls \`undefined\` as soon as React attaches the element and the
dashboard subtree crashes. The current DynamicComponent shard also has all 13
tests failing on this new callable-only assumption. Can this guard the optional
connector and keep the edit-mode mock callable?
##########
superset-frontend/package.json:
##########
@@ -196,20 +196,19 @@
"postcss": "^8.5.28",
"query-string": "9.5.1",
"re-resizable": "^6.11.2",
- "react": "^18.3.0",
+ "react": "^19.2.0",
"react-arborist": "^3.16.0",
- "react-checkbox-tree": "^1.8.0",
+ "react-checkbox-tree": "^2.0.1",
Review Comment:
The 2.x package renders the global controls and labels as \`.rct-actions\`
and \`.rct-label\`, but \`FilterScopeSelector\` still overrides the removed
\`.rct-options\` and \`.rct-title\` hooks. That makes Expand/Collapse regain
the library's right alignment and lose its bottom spacing, and the root label
loses its strong weight. Can those selectors be migrated with this bump?
##########
superset-frontend/packages/superset-ui-core/src/chart/components/reactify.tsx:
##########
@@ -26,11 +26,21 @@ import {
} from 'react';
import type {
ComponentType,
- WeakValidationMap,
ForwardRefExoticComponent,
PropsWithoutRef,
RefAttributes,
} from 'react';
+import type { Validator } from 'prop-types';
Review Comment:
Downstream TypeScript consumers can now fail with \`TS2307\` while resolving
this public declaration: \`Validator\` flows into the exported
\`RenderFuncType\`, but \`@types/prop-types\` is only a devDependency, and
\`@types/react@19\` no longer supplies it transitively. Can the package declare
this type dependency or make the emitted declaration self-contained?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
