aminghadersohi commented on code in PR #44180:
URL: https://github.com/apache/superset/pull/44180#discussion_r4024225150
##########
superset/views/core.py:
##########
@@ -681,7 +681,7 @@ def fetch_datasource_metadata(self) -> FlaskResponse:
)
# Check if datasource exists
if not datasource:
- return json_error_response(DATASOURCE_MISSING_ERR)
+ return json_error_response(str(DATASOURCE_MISSING_ERR))
Review Comment:
Retracting the consequence half of this: your merge pulled in #44090, which
added an `elif isinstance(error_details, LazyString)` branch, so dropping this
`str()` now yields a byte-identical body (measured). Redundant rather than
load-bearing — nothing to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
