bito-code-review[bot] commented on PR #44345:
URL: https://github.com/apache/superset/pull/44345#issuecomment-5696297321
<!-- Bito Reply -->
The flagged issue is correct. The added guard `if (!activeKey) { return; }`
prevents the component from dispatching an `undefined` tab ID when the TABS
component is empty, which avoids polluting the `activeTabs` state with `null`
values during serialization.
To resolve this, the current implementation is already correct as it
effectively prevents the registration of an invalid tab state. No further
changes are required for this specific issue.
**superset-frontend/src/dashboard/components/gridComponents/Tabs/Tabs.tsx**
```
if (!activeKey) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
