bito-code-review[bot] commented on PR #44273: URL: https://github.com/apache/superset/pull/44273#issuecomment-5698802420
<!-- Bito Reply --> The review suggestion is correct. The PR diff confirms that the implementation has already been updated to use `df_10m` (1:10m geometry) instead of the previous source, which addresses the performance concern regarding the large payload size of the 1:50m data. No further action is required for this specific issue as the fix is already present in the provided diff. **superset-frontend/plugins/plugin-chart-country-map/scripts/Country Map GeoJSON Generator.ipynb** ``` - "russia = df[df.admin == 'Russia']\n", + "russia = df_10m[(df_10m.admin == 'Russia') & df_10m.name.notna()]\n", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
