sadpandajoe commented on code in PR #42618:
URL: https://github.com/apache/superset/pull/42618#discussion_r4027758555
##########
superset-frontend/src/pages/AlertReportList/index.tsx:
##########
@@ -190,23 +190,31 @@ function AlertList({
}
executingIdsRef.current.add(alertId);
+ const isReport = alert.type === 'Report';
executeReport(
alertId,
() => {
addSuccessToast(
- t('%(alertType)s "%(alertName)s" triggered successfully', {
- alertType: alert.type,
- alertName: alert.name,
- }),
+ isReport
+ ? t('Report "%(alertName)s" triggered successfully', {
Review Comment:
These new msgids have no catalog entries, while the replaced keys currently
have Japanese and Portuguese translations, so those locales fall back to an
English toast after this change. Could we add explicit translations for all
four Alert/Report messages without carrying over the removed `%(alertType)s`
placeholder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
