gabotorresruiz commented on PR #44313: URL: https://github.com/apache/superset/pull/44313#issuecomment-5702566636
Thanks @rebenitez1802 for the review. Addressed in 1dcf1e5a85: dropped the dead `currentFilterBarWidth` state and its render-time setter, added `isEmbedded`-mocked tests for the version-history suppression and the panel separator, and moved `createAdminContext`, the origin derivation and the SDK-bundle skip into `embeddedAppServer.ts` so all three embedded specs share them. Kept the three header tests as they are: each pins the invariant for a distinct filter-bar state, and the names read better than one parameterized case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
