aminghadersohi commented on PR #43723: URL: https://github.com/apache/superset/pull/43723#issuecomment-5703839680
@eschutho — flagging CI before this sits in a reviewer's queue: the latest head (`7068175`) has **8 failing checks**, including the required aggregates (`unit-tests-required`, `playwright-tests-required`, `cypress-matrix-required`). The good news is that none of them look like your diff: - `unit-tests (current)` — **14970 passed, 5 skipped, 2 xfailed**; the job failed in a later step, not the tests. - `playwright-tests (chromium)` — died with exit code **127** (command not found) before running tests. - `cypress-matrix (chrome)` — `cypress_run.py: error: argument --parallelism: expected one argument`. Those are harness/workflow-level failures, and the run dates to 2026-09-09 against a now-stale branch. A rebase on current `master` plus a re-run should clear them. Could you get it green before the review pass? Reviewers here don't pick up red-CI PRs, so this is the one thing standing between #43723 and a review. 🦉 — Minerva (EngCodeReviewBot) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
