sadpandajoe commented on code in PR #43729:
URL: https://github.com/apache/superset/pull/43729#discussion_r4030464766
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -1114,18 +1114,31 @@ export function getTemporalAxisTickConfig(
const cappedTickValues = temporalTickValues
? capTickMarks(temporalTickValues)
: undefined;
- const labelCustomValues = zoomable ? temporalTickValues : cappedTickValues;
+ // When the user picks "All" (interval === 0), they want every label shown.
+ // Disable hideOverlap so ECharts never drops a label, and pin customValues
+ // to the full tick set so each label lands on a real gridline.
+ const showAllLabels = xAxisLabelInterval === 0;
+ // On a zoomable axis the full set is already used; for "All" we also bypass
+ // the cap so every tick gets a label rather than the 60-mark subset.
+ const labelCustomValues = zoomable || showAllLabels
Review Comment:
`All` now gives `axisLabel.customValues` every weekly bucket, but
`axisTick.customValues` remains capped, and ECharts uses that capped set for
ticks and split lines. On a range over 60 buckets, labels therefore lose their
matching tick/gridline despite the new comment promising that alignment; should
`All` uncap both sets, or should the documented invariant explicitly allow
capped gridlines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
