anamitraadhikari commented on PR #44165: URL: https://github.com/apache/superset/pull/44165#issuecomment-5704262790
> ### Code Review Agent Run #8fb7bf > Actionable Suggestions - 0 > Additional Suggestions - 1 > Review Details > Bito Usage Guide > AI Code Review powered by [<img alt="Bito Logo" width="50" height="20" src="https://camo.githubusercontent.com/810f9c950a15f18a9a21d4e214820ef360ea3b08a4b5dea95d24529fffd09ed6/68747470733a2f2f6269746f2e61692f77702d636f6e74656e742f75706c6f6164732f323032332f31302f4c6f676f2d4269746f2d426c61636b2d63726f707065642e737667";>](https://bito.ai/) Fair point, this mock doesn't change the assertion. The fullscreen label comes from getUrlParam(URL_PARAMS.standalone), which reads window.location.search, and that is already set by pushState on the line below. It is deliberate though. The shared useLocation mock at the top of the file hardcodes search: '?standalone=1' for every test, so without the override this test would be asserting non standalone behaviour while the router mock still claims standalone. That is confusing to read even if it is inert, and an earlier run of this same bot (#66de0e) flagged exactly that inconsistency as worth fixing, which is why the override was added. Happy to drop it if reviewers prefer the smaller diff. Either way it is test only, zero behavioural impact, and both runs marked it as non actionable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
