rusackas commented on PR #42477: URL: https://github.com/apache/superset/pull/42477#issuecomment-5704624529
@ariel-sofi one thing before this can merge, though: pre-commit's failing on `manager.py`, ruff's flagging `_collect_sortable_identifiers` as too complex now and mypy's unhappy with the orderby type in the new test. Once that's cleared we're good. Also, a few of Codeant's threads look like they could use a pass to mark resolved now that they've been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
