aminghadersohi commented on PR #44349: URL: https://github.com/apache/superset/pull/44349#issuecomment-5705549168
Good catch on the missing opt-out coverage — added in `eda957c9bd`, tests only. Two tests in `tests/unit_tests/commands/deletion_retention/test_prune_audit.py`: - `test_delete_batch_skips_the_locked_scope_lookup_when_the_category_opts_out` — the mirror of the existing scoped-path test. Asserts `recheck_predicates` is called as `(table)` with `scope_entities` **absent from kwargs**, not passed empty, and pins the statement order under the lock as `execute, rollback, lock, execute, execute, commit` — exactly one fewer execute between the lock and the commit than the scoped path takes. - `test_only_the_evidence_category_opts_out_of_the_locked_scope_lookup` — pins the wiring, so the flag can't be declared and then not reach `_delete_batch`: `[(_duplicate_predicates, True), (_operational_predicates, True), (_evidence_predicates, False)]`. Verified they can actually fail: dropping `needs_entity_scope=False` from the evidence category and forcing the scope lookup back on in `_delete_batch` turns both red (`At index 2 diff: (_evidence_predicates, True) != (_evidence_predicates, False)`); reverted, and `prune_audit.py` is byte-identical to the previous head. 112 passed in the directory (was 110), pre-commit clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
