mikebridge commented on PR #44251: URL: https://github.com/apache/superset/pull/44251#issuecomment-5705769889
Follow-up to the Bito notes in https://github.com/apache/superset/pull/44251#issuecomment-5668401610 and https://github.com/apache/superset/pull/44251#issuecomment-5671326859: 7797be4e014d21e82cfc724fd430ab31882ac5e1 reuses the canonical INSERT/DELETE constants, documents the test helpers and hoists their import, corrects the refusal assertion's scope to ORM changes (not the deliberate Core DELETE), and removes the obsolete foreign-witness log comment. The born-after indistinguishability is documented, not claimed solved: retention preservation remains post-GA sc-120945. Verification: 180 versioning unit tests passed; SQLite integration 9 passed / 1 server-dialect test skipped; full branch changed-file pre-commit passed. Independent source review found no publication blocker, with three documentation nits retained. New-head CI is pending, so this is not an all-green or all-feedback-resolved claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
