rusackas commented on a change in pull request #8633: Font styling consolidation
URL:
https://github.com/apache/incubator-superset/pull/8633#discussion_r350477784
##########
File path: superset/assets/src/CRUD/crud.less
##########
@@ -24,24 +26,24 @@
padding: 10px;
}
.control-label {
- font-weight: bold;
- font-size: 16px;
+ font-weight: @font-weight-bold;
+ font-size: @font-size-l;
Review comment:
While I also like to be explicit, I thought it might be better to be
systematic, and go with "t-shirt sizes" ranging from `xxs`, `xs`, `s`, `m`,
`l`, `xl`, `xxl`. If we go with `font-size-large` I'd also want to go with
`font-size-extraExtraLarge` or `font-size-extra-extra-large` but those seemed
goofy :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
