codeant-ai-for-open-source[bot] commented on code in PR #44184:
URL: https://github.com/apache/superset/pull/44184#discussion_r4032793432
##########
superset/commands/dataset/update.py:
##########
@@ -151,6 +152,13 @@ def _validate_dataset_source(self, exceptions:
list[ValidationError]) -> None:
table,
self._model_id,
):
+ # Same hidden-twin guidance as the create path: when the blocking
+ # row is a SOFT-DELETED dataset, raise the targeted 422 naming
+ # the twin's uuid and the restore pointer instead of the opaque
+ # "already exists" (the twin is invisible in the caller's list).
+ soft_twin: SqlaTable | None
+ if soft_twin := DatasetDAO.find_soft_deleted_logical_duplicate(db,
table):
+ raise DatasetSoftDeletedTwinExistsError(str(soft_twin.uuid))
Review Comment:
**Suggestion:** `update_dataset_metric` does not catch this command
exception, so a soft-deleted collision escapes as an unexpected MCP failure
instead of the structured validation response used previously.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9307e51c824a4242baebc5d7638d4dee&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9307e51c824a4242baebc5d7638d4dee&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/dataset/update.py
**Line:** 160:161
**Comment:**
*Api Mismatch: `update_dataset_metric` does not catch this command
exception, so a soft-deleted collision escapes as an unexpected MCP failure
instead of the structured validation response used previously.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44184&comment_hash=6cf6f850a4288db57623c41fbc47d8310f49e7983a97ad859272091b23fa650f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44184&comment_hash=6cf6f850a4288db57623c41fbc47d8310f49e7983a97ad859272091b23fa650f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
