tien238lnd commented on PR #44338: URL: https://github.com/apache/superset/pull/44338#issuecomment-5708519615
@gabotorresruiz Addressed in 222adb3d14. I also rebased onto master to resolve the conflict with #43828: `_dump_chart_info` now returns `ChartInfo` through `cast`, like the other return paths in the tool. - SQL Lab query permalinks: your `datasource_name` / `name` fallback, plus a test with a real `Query`. - Query access denied (`SupersetSecurityException`) now returns `PermalinkAccessDenied`, and a broken query template (`SupersetTemplateException`) returns `InvalidPermalink`. Both were escaping the tool, as Copilot and CodeAnt noted. - The unsaved-permalink path now fills `chart_type_display_name` as well, so both permalink paths return the same viz fields (from Bito's review). Bito also noted that `form_data_key` is silently dropped when both keys are passed. That request never reaches the tool: `GetChartInfoRequest` rejects it with "Provide either 'form_data_key' or 'permalink_key', not both.", covered by `test_request_rejects_permalink_key_with_form_data_key`. `pytest tests/unit_tests/mcp_service` on this head: 4316 passed, 1 skipped, and the same two `test_query_dataset.py` failures you saw at the parent commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
