mikebridge commented on PR #44169: URL: https://github.com/apache/superset/pull/44169#issuecomment-5708817469
@Kunal8954 — routing a concrete dashboard regression from SC-120295 / preset-io/superset-shell#5140 to the existing SC-120289 host work. This extends the dashboard metadata concern in https://github.com/apache/superset/pull/44169#discussion_r4016953019; it is separate from MCP dashboard serialization #44269. On core `2db9d6d51c8623810a2dba5b796c5154147d7d76`, an isolated dashboard with semantic-view Table, BigNumber and monthly charts renders valid numeric results. With malformed, NaN or overflowing numeric input, all three chart requests correctly return HTTP 400 with a bounded metric/category message, and frontend Redux reaches `failed` with that message. The visible dashboard nevertheless shows loading indicators: `/api/v1/dashboard/1/datasets` returns `{"result":[]}`, so it retains `PLACEHOLDER_DATASOURCE`, and `components/Chart/Chart.tsx` suppresses message-only errors in that state. Source inspection at your current `ff4829b8308c49e92942df3f53c510238c87525c` still shows the relevant path: `Dashboard.datasets_trimmed_for_slices` reads `next(iter(slices)).datasource`, while `Slice.datasource` returns only `self.table`; the placeholder guard is also present. This is source confirmation at your head, not a browser rerun of your branch. No changes made to your branch. Suggested regression coverage: a semantic-only dashboard must supply its authorized datasource metadata; a mixed table/semantic dashboard with colliding integer IDs must keep both identities distinct; a semantic query HTTP400 must produce a visible terminal error rather than a spinner. Preserve the existing access checks/type boundaries. Numeric's valid rendering is verified with mocked remote GraphQL/Arrow and real provider/host/frontend; its visible-error gate remains open pending the host fix. Local reproducible scripts, screenshots, response bodies and Redux evidence are saved under `superset-spec/specs/sc-120295-metricflow-numeric-contract/validation/browser-foundation-20260916/` (no live-provider or production claim). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
