mikebridge commented on PR #44262: URL: https://github.com/apache/superset/pull/44262#issuecomment-5708834664
Prepared by Codex at Mike's request. Feedback accounting at `db03401048de06282835bab5e86bf37db2f407ff`: original five inline findings have individual remediation/evidence replies (starting https://github.com/apache/superset/pull/44262#discussion_r4031489900). The two newer cross-product/discovery-cost comments are acknowledged as retained limitations, not claimed fixed: https://github.com/apache/superset/pull/44262#discussion_r4033213656 and https://github.com/apache/superset/pull/44262#discussion_r4033213782 . Bito's original fallback and unused-scope points map to those existing fixes; its boundary-logic duplication suggestion is left as a structural follow-up, with semantics pinned by differential tests rather than another rewrite in this packet. Repaired-master PostgreSQL CI completes `2791 passed, 165 skipped`: https://github.com/apache/superset/actions/runs/35166198065/job/105027831036 . This supersedes the earlier multiple-head setup failure. The ratified default50/max100, legacy/unknown-version fallback and no O(batch) guarantee remain. Prior audit follow-ups (backlog metric ambiguity, read-only transaction lifetime, scope-test fence and dialect dispatch evidence) are not silently marked fixed. #44349 remains Amin-owned and downstream; no MySQL5.7/MariaDB live execution or production-capacity validation is claimed. Reviewer acceptance remains outstanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
