aminghadersohi commented on code in PR #44337:
URL: https://github.com/apache/superset/pull/44337#discussion_r4035100146
##########
tests/unit_tests/mcp_service/dataset/tool/test_dataset_tools.py:
##########
@@ -98,6 +98,7 @@ def create_mock_dataset(
dataset.template_params = {}
dataset.extra = {}
dataset.uuid = f"test-dataset-uuid-{dataset_id}"
+ dataset.deleted_at = None
Review Comment:
The 14 bare `dataset = MagicMock()` sites here bypass this fixture and still
omit `deleted_at`. Measured: `serialize_dataset_object` then returns
`1970-01-01T00:00:01Z` (MagicMock `__int__`→1, coerced by `str | datetime |
None`) — they read as trashed. Silent, not a ValidationError.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
