bito-code-review[bot] commented on PR #44387:
URL: https://github.com/apache/superset/pull/44387#issuecomment-5713630626
<!-- Bito Reply -->
The requested change has been implemented in
`superset/mcp_service/middleware.py`. The `QueryObjectValidationError` class
has been removed from the `_DATASOURCE_ERROR_EXCEPTIONS` tuple, ensuring that
such errors are no longer incorrectly classified as datasource-related
failures. This prevents the misleading error message that previously suggested
the tool name and arguments were valid when a query validation error occurred.
**superset/mcp_service/middleware.py**
```
# Exception classes that mean "the query behind this tool failed", not "the
# caller used the tool wrong". The tool name and arguments were valid; the
# datasource, table, column, or connection it reads is broken or gone.
_DATASOURCE_ERROR_EXCEPTIONS = (
ColumnNotFoundException,
DatabaseNotFound,
SupersetGenericDBErrorException,
SupersetParseError,
SupersetTimeoutException,
SupersetVizException,
SQLAlchemyError,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
