eschutho commented on PR #44390:
URL: https://github.com/apache/superset/pull/44390#issuecomment-5716844621

   @richardfogaca assigning you to review this one. Small backend fix — 
`superset/commands/importers/v1/utils.py` (+4) plus a regression test: binds 
`config: Any = None` before the `load_configs` try-block so the `except 
ValidationError` diagnostic (`isinstance(config, dict)`) can't raise 
`UnboundLocalError` when `load_yaml` itself fails on unparseable YAML (Sentry 
SUPERSET-PYTHON-176W, SC-121288).
   
   Routed to you on continuity with the eschutho raw-exception→ValidationError 
cleanup series you've been reviewing (#44204, #43517/#43520) — Rafael's the 
other series reviewer but he's at capacity. No CODEOWNERS gate on the path; CI 
green so far. No rush.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to